fix: More Int128 testing and related fixes

[lukemanley]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.02%. Comparing base (f5f4cb5) to head (78cad88).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/polars-python/src/series/map.rs	0.00%	8 Missing ⚠️
...tes/polars-ops/src/chunked_array/array/sum_mean.rs	0.00%	6 Missing ⚠️
crates/polars-python/src/map/series.rs	57.14%	3 Missing ⚠️
...ates/polars-ops/src/chunked_array/list/sum_mean.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #20494      +/-   ##
==========================================
- Coverage   79.02%   79.02%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      220557   220609      +52     
  Branches     2492     2502      +10     
==========================================
+ Hits       174300   174335      +35     
- Misses      45684    45700      +16     
- Partials      573      574       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ritchie46]

This is maybe a misnomer, as Pyarrow doesn't support i128 primitive type.

Looking at this code, I also don't understand why we have this trait. Maybe we can remove it and replace the PyArrowPrimitiveType with PolarsNumericType.

[lukemanley]

Yeah, I think PyArrowPrimitiveType is a misnomer here. I renamed this to PyPolarsNumericType.

I tried replacing it entirely with PolarsNumericType as you suggested but couldn't figure out how to get around this build error:

error[E0119]: conflicting implementations of trait `ApplyLambda<'_>` for type `polars::prelude::ChunkedArray<polars::prelude::BooleanType>`
   --> crates/polars-python/src/map/series.rs:571:1
    |
280 |   impl<'a> ApplyLambda<'a> for BooleanChunked {
    |   ------------------------------------------- first implementation here
...
571 | / impl<'a, T> ApplyLambda<'a> for ChunkedArray<T>
572 | | where
573 | |     T: PolarsNumericType,
574 | |     T::Native: IntoPyObject<'a> + FromPyObject<'a>,
575 | |     ChunkedArray<T>: IntoSeries,
    | |________________________________^ conflicting implementation for `polars::prelude::ChunkedArray<polars::prelude::BooleanType>`
    |
    = note: upstream crates may add a new impl of trait `polars::prelude::PolarsNumericType` for type `polars::prelude::BooleanType` in future versions

It appears there is a similar trait PolarsOpsNumericType used in a similar way here:

polars/crates/polars-ops/src/chunked_array/scatter.rs

Line 32 in b430f64

trait PolarsOpsNumericType: PolarsNumericType {}

[ritchie46]

Ah, there we have the reason for this new trait. :)

[ritchie46]

Again, looks great. Thanks a lot @lukemanley