Initial support for asynchronous suiciding #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Oct 1, 2023
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
|
I think an additional extrinsic like |
|
@sorpaas can you also add a check to prevent to redeploy a contract if the contract address is suicided?
That can be part of another PR (I can work on it). Note that we can also implement this extrinsic directly on moonbeam. |
boundless-forest
pushed a commit
to darwinia-network/frontier
that referenced
this pull request
Oct 7, 2023
* Initial support for asynchronous suiciding * Use contains_key instead of is_some Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> * Fix compile * Remove unnecessary Suicided check * Don't call dec_sufficients * Handle pre-EIP161 case * Add extra safeguard * Always inc nonce * Fix tests --------- Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
koushiro
pushed a commit
to alt-research/frontier
that referenced
this pull request
Oct 13, 2023
* Initial support for asynchronous suiciding * Use contains_key instead of is_some Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> * Fix compile * Remove unnecessary Suicided check * Don't call dec_sufficients * Handle pre-EIP161 case * Add extra safeguard * Always inc nonce * Fix tests --------- Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
ahmadkaouk
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Nov 2, 2023
* Initial support for asynchronous suiciding * Use contains_key instead of is_some Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> * Fix compile * Remove unnecessary Suicided check * Don't call dec_sufficients * Handle pre-EIP161 case * Add extra safeguard * Always inc nonce * Fix tests --------- Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
boundless-forest
pushed a commit
to darwinia-network/frontier
that referenced
this pull request
Nov 8, 2023
* Initial support for asynchronous suiciding * Use contains_key instead of is_some Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> * Fix compile * Remove unnecessary Suicided check * Don't call dec_sufficients * Handle pre-EIP161 case * Add extra safeguard * Always inc nonce * Fix tests --------- Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
sorpaas
added a commit
that referenced
this pull request
Nov 9, 2023
* Initial support for asynchronous suiciding * Use contains_key instead of is_some * Fix compile * Remove unnecessary Suicided check * Don't call dec_sufficients * Handle pre-EIP161 case * Add extra safeguard * Always inc nonce * Fix tests --------- Co-authored-by: Wei Tang <wei@pacna.org> Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for async suiciding. We might also want to add a governance dispatchable in the future so that storages can be cleared, if needed.