-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reapply changes since v1.1.0-rc2
import
#172
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
/merge |
Enabled Available commands
For more information see the documentation |
Is there a written down identity migration plan? How long will the migration to take? Are UI devs aware of this? Any announcement post? I will either block merge of this PR or the release of the next runtime until those questions are addressed. However, given that I will most likely going to block the next runtime release due to other reasons (lack of tests), so maybe I will let this pass and just add one more reason to block the next runtime release. |
We don't want to block Identity calls yet. We need at least Polkadot SDK v1.7.0 to start the migration, and we will do Kusama only first. For now, Once we have 1.7.0, I will make a PR with a People Chain runtime and blocking Kusama Identity calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @joepetrowski comment
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
This reverts commit fc9da09. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Reverted the identity changes to both runtimes. |
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@xlc PTAL PS: Nvm looks like the review bot was happy. |
We imported the runtimes into this repo at tag
v1.1.0-rc2
but still merged stuff until they got removed in #1731.This re-applies all changes in that commit range
v1.1.0-rc2..bf90cb0b
checked in the SDK withgit log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/
. Closes #112Most changes got applied as part of #56, but two were missing:
SafeCallFilter
from Relay Runtimes paritytech/polkadot-sdk#1303Disable Calls to Identity Pallet paritytech/polkadot-sdk#1476(reverted)One open Q since there was a difference between #1291 and #67.