add Signer to api #662
Merged
add Signer to api #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
requested changes
Feb 4, 2019
There was a problem hiding this comment.
Some small comments. (Additionally there are some linting issues that is making CI unhappy, mostly white-spacing)
Overall, I think this does fit the bill exactly as described in #660 and def. adds overall value in moving the API along. Thank you!
amaury1093
approved these changes
Feb 5, 2019
jacogr
approved these changes
Feb 5, 2019
|
@jacogr when can this pr get merged? |
|
Sorry, they have been heaping up a bit, all of them. (I have been a bottleneck this week) |
This was referenced Feb 9, 2019
Closed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #660