Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Signer interface for API #683

Merged
merged 10 commits into from
Feb 12, 2019
Merged

Add Signer interface for API #683

merged 10 commits into from
Feb 12, 2019

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Feb 9, 2019 •
edited
Loading

@jacogr jacogr added the WIP Work in Progress label Feb 9, 2019
@jacogr jacogr removed the WIP Work in Progress label Feb 11, 2019
@jacogr jacogr added the WIP Work in Progress label Feb 11, 2019
@jacogr jacogr removed the WIP Work in Progress label Feb 11, 2019
jacogr
jacogr commented Feb 11, 2019
View reviewed changes
packages/app-js/src/snippets/transfer.ts
// This software may be modified and distributed under the terms
// of the Apache-2.0 license. See the LICENSE file for details.

export default `// transfer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I need to turn this into a proper snippet - will do that next round along with the queries one I added earlier.

@jacogr jacogr merged commit 61674a7 into master Feb 12, 2019
@jacogr jacogr deleted the jg-ui-signer branch February 12, 2019 21:29
Stefie added a commit that referenced this pull request Feb 13, 2019
@Stefie
Merge branch 'sd-app-js-follow-up-tasks' of github.com:polkadot-js/ap…
3bfb85d 
…ps into sd-app-js-follow-up-tasks

# By Jaco Greeff (2) and Travis CI (2)
# Via Jaco Greeff (2) and Travis CI (1)
* 'sd-app-js-follow-up-tasks' of github.com:polkadot-js/apps:
  [CI Skip]  0.23.18
  Add Signer interface for API (#683)
  [CI Skip]  0.23.17
  Bump API (#702)
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 11, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate api-signer (instead of using signer queue)
2 participants
@jacogr @polkadot-js-bot