Skip to content

P1) Update typescript client to remove warnings #7

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

RichardDzurus
Copy link
Contributor

solves issue

  • uses ts-json-schema-generator instead of no longer supported typescript-json-schema so there is a little logic rewrite
  • upgraded eslint version and migrated config

Note: I tried deploying functions to dev using this version different kinds of types and it seemed fine but @aarongoin you might be more familiar with some edge cases as you worked with schemas in other parts - if you got few extra minutes could you try maybe I missed something

@RichardDzurus RichardDzurus requested a review from aarongoin May 23, 2025 18:02
@aarongoin
Copy link
Member

So far this okay to me. Will pull this branch and test more on Tuesday. 👍

Copy link
Member

@aarongoin aarongoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say lets merge this one. But heads up you'll need to update to use a different version as we're already on 0.23.17

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants