docker github action test #325
Conversation
acloudiator
requested review from
palexster,
sebymiano,
goldenrye and
smagnani96
| @@ -9,7 +9,8 @@ FROM ubuntu:18.04 AS builder | |||
|
|
|||
| ARG DEFAULT_MODE=default | |||
| ENV MODE=$DEFAULT_MODE | |||
| RUN --mount=target=/polycube cp -r /polycube /tmp/polycube && cd /tmp/polycube && \ | |||
| COPY /polycube/ /tmp/polycube | |||
There was a problem hiding this comment.
Shouldn't it be COPY . /tmp/polycube/? I'm scared that COPY /polycube/ ... fails because, when building, the process is already inside the directory.
RUN --mount=target=/polycube was used to already mount the current directory to /polycube. If we want to use COPY then it should be fixed
| run: | | ||
| pwd | ||
| cd .. | ||
| ls -ltr |
There was a problem hiding this comment.
Try also by adding export DOCKER_BUILDKIT=1 in this file, before the build command
There was a problem hiding this comment.
Buildkit doesn't seems to be supported by github action. We need to get rid of this mount, last time I checked it was an experimental feature.
There was a problem hiding this comment.
I found this discussion docker-archive/github-actions#12 (comment) where somebody said that DOCKER_BUILDKIT is supported on Github Actions. I do not know if it is true or not, but maybe we could try to insert env: DOCKER_BUILDKIT:1 as reported in this yml file https://github.com/docker/github-actions/blob/826b584752ffa6abc1a2d94da26f348e3e4f73d0/.github/workflows/main.yml#L26
test with buildkit
|
Superseded by #364 |
Docker github action to test the build based with event trigger