Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix "iftype" expressions not being usable in lambdas or object literals #3763

Merged
merged 1 commit into from
May 27, 2021

Conversation

ergl
Copy link
Member

@ergl ergl commented May 23, 2021

Fixes #3762, but paging @jemc just in case he thinks if this should be fixed somewhere else in the compiler

@ergl ergl requested a review from jemc May 23, 2021 21:15
@ergl ergl force-pushed the ergl/fix-3762 branch from bc9c5e3 to cbfae21 Compare May 23, 2021 21:28
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label May 24, 2021
@ponylang-main
Copy link
Contributor

Hi @ergl,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3763.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member

@ergl i merge this once release notes are added and you switch from draft to ready for review.

@ergl
Copy link
Member Author

ergl commented May 26, 2021

@SeanTAllen Ok, I'll get to it later today

@ergl ergl force-pushed the ergl/fix-3762 branch from cbfae21 to 123fa69 Compare May 27, 2021 10:49
@ergl ergl marked this pull request as ready for review May 27, 2021 10:50
@ergl ergl force-pushed the ergl/fix-3762 branch from 123fa69 to fbbee49 Compare May 27, 2021 10:50
@ergl ergl changed the title Fix assertion error on iftype inside lambdas Fix "iftype" expressions not being usable in lambdas or object literals May 27, 2021
@SeanTAllen SeanTAllen merged commit 29431e4 into main May 27, 2021
@SeanTAllen SeanTAllen deleted the ergl/fix-3762 branch May 27, 2021 11:54
github-actions bot pushed a commit that referenced this pull request May 27, 2021
github-actions bot pushed a commit that referenced this pull request May 27, 2021
@redvers redvers mentioned this pull request Jul 7, 2021
11 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expr pass: Assertion error on iftype inside lambda
4 participants