Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix non-release build crashes on Arm #3860

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Fix non-release build crashes on Arm #3860

merged 1 commit into from
Sep 18, 2021

Conversation

SeanTAllen
Copy link
Member

The code removed in this commit dates to the very first Arm 32 support
that Sylvan added. It appears during the elapsed years, that the bug
that was being worked around was fixed. The workaround is now itself
a source of odd behavior and crashes for me as I try to get main
working on a Raspberry Pi 4 running a 32-bit version of Raspbian.

With the code as it stands before this patch is applied, I get
crashes when running the standard library tests in debug mode. I
can reliably reproduce using the serialise tests but it was
also happening "randomly" with other tests as well.

After removing Sylvan's workaround, I have seen a total lack of the
issue.

Closes #3851

@SeanTAllen SeanTAllen requested a review from a team September 17, 2021 12:26
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Sep 17, 2021
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3860.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

The code removed in this commit dates to the very first Arm 32 support
that Sylvan added. It appears during the elapsed years, that the bug
that was being worked around was fixed. The workaround is now itself
a source of odd behavior and crashes for me as I try to get `main`
working on a Raspberry Pi 4 running a 32-bit version of Raspbian.

With the code as it stands before this patch is applied, I get
crashes when running the standard library tests in debug mode. I
can reliably reproduce using the `serialise` tests but it was
also happening "randomly" with other tests as well.

After removing Sylvan's workaround, I have seen a total lack of the
issue.

Closes #3851
@SeanTAllen SeanTAllen merged commit 5652869 into main Sep 18, 2021
@SeanTAllen SeanTAllen deleted the arm-debug-fix branch September 18, 2021 02:22
github-actions bot pushed a commit that referenced this pull request Sep 18, 2021
github-actions bot pushed a commit that referenced this pull request Sep 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialise/Failures stdlib test aborts on 32 bit Arm
3 participants