Fix non-release build crashes on Arm #3860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code removed in this commit dates to the very first Arm 32 support
that Sylvan added. It appears during the elapsed years, that the bug
that was being worked around was fixed. The workaround is now itself
a source of odd behavior and crashes for me as I try to get
main
working on a Raspberry Pi 4 running a 32-bit version of Raspbian.
With the code as it stands before this patch is applied, I get
crashes when running the standard library tests in debug mode. I
can reliably reproduce using the
serialise
tests but it wasalso happening "randomly" with other tests as well.
After removing Sylvan's workaround, I have seen a total lack of the
issue.
Closes #3851