Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix crash when calling (this.)create() #4263

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Conversation

chalcolith
Copy link
Member

This PR removes a superfluous receiver cap check when trying to autorecover a create expression in an assignment. That check could assert when calling create() (with implicit this).

Fixes #4259

This PR removes a superfluous receiver cap check when trying to autorecover a create expression in an assignment.  That check could assert when calling `create()` (with implicit `this`).
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Nov 30, 2022
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Nov 30, 2022
@ponylang-main
Copy link
Contributor

Hi @kulibali,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4263.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen merged commit aaa55e7 into main Nov 30, 2022
@SeanTAllen SeanTAllen deleted the issue_4259_ctor_crash branch November 30, 2022 19:46
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Nov 30, 2022
github-actions bot pushed a commit that referenced this pull request Nov 30, 2022
github-actions bot pushed a commit that referenced this pull request Nov 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling constructor and storing crashes ponyc
3 participants