-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove ambiguity from "not safe to write" compiler error message #4299
Conversation
This should have a test. |
@jemc @jasoncarr0 because i got turned around a little with this, can one of you review this as well? |
Hi @kidandcat, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
.release-notes/4299.md
Outdated
@@ -0,0 +1,3 @@ | |||
## Fix vague error message when it is not safe to write | |||
|
|||
Added left side type to a "not safe to write" error message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely to be lacking in meaning for a reader of the release notes who doesn't have your context.
Please include what the error message used to be, why that was vague, and how the new version of the message fixes the vagueness.
Co-authored-by: Sean T Allen <sean@seantallen.com>
Fixes #4290
With this change, the error becomes:
(First time contributing to ponyc + first time contributing in C) triple check the change please 😅