Update DTrace probes #4302
Update DTrace probes #4302
Conversation
ponylang-main
added
the
discuss during sync
|
@jemc thoughts on if this needs a CHANGELOG entry and release notes? |
SeanTAllen
force-pushed
the
issue-4296
branch
from
28f0974 to
093a418
Compare
| */ | ||
| probe gc__start(uintptr_t scheduler); | ||
| probe gc__start(uintptr_t scheduler, uintptr_t actor); |
There was a problem hiding this comment.
this one was incorrect and was already taking the actor.
| */ | ||
| probe gc__recv__start(uintptr_t scheduler); | ||
| probe gc__recv__start(uintptr_t scheduler, uintptr_t actor); |
There was a problem hiding this comment.
added actor to trace.
| */ | ||
| probe gc__recv__end(uintptr_t scheduler); | ||
| probe gc__recv__end(uintptr_t scheduler, uintptr_t actor); |
There was a problem hiding this comment.
added actor to trace.
| */ | ||
| probe gc__send__start(uintptr_t scheduler); | ||
| probe gc__send__start(uintptr_t scheduler, uintptr_t actor); |
There was a problem hiding this comment.
added actor to trace.
| */ | ||
| probe gc__send__end(uintptr_t scheduler); | ||
| probe gc__send__end(uintptr_t scheduler, uintptr_t actor); |
There was a problem hiding this comment.
added actor to trace.
| */ | ||
| probe gc__end(uintptr_t scheduler); | ||
| probe gc__end(uintptr_t scheduler, uintptr_t actor); |
SeanTAllen
force-pushed
the
issue-4296
branch
2 times, most recently
from
05ad078 to
626936e
Compare
|
A close review to make sure I didn't fubar anything would be appreciated. |
I don't know much about how dtrace is used, but my initial thought would be yes, a changelog entry would be nice. |
SeanTAllen
added
do not merge
|
Hi @SeanTAllen, The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be: Thanks. |
A user opened #4296 and noted that the probes were out of date. The names of @params in comments need to match the names in the function definitions. While exploring the issue, I found that some functions lacked param definitions, some had missing params, some had misnamed params, and some functions were lacking useful information such as the actor in being run where only the scheduler was present and the actor is the most useful bit of information. This commit fixes all the issues I found and in the process closes the original issue. Fixes #4296
SeanTAllen
force-pushed
the
issue-4296
branch
from
626936e to
b7ac8d3
Compare
|
Release notes added. |
ponylang-main
removed
the
discuss during sync
A user opened #4296 and noted that the probes were out of date. The names of @params in comments need to match the names in the function definitions.
While exploring the issue, I found that some functions lacked param definitions, some had missing params, some had misnamed params, and some functions were lacking useful information such as the actor in being run where only the scheduler was present and the actor is the most useful bit of information.
This commit fixes all the issues I found and in the process closes the original issue.
Fixes #4296