Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix being unable to compile programs that use runtime info on Windows #4625

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

SeanTAllen
Copy link
Member

Note this would have been caught much earlier if we were building examples on Windows as part of CI as there is a runtime info example that would fail on Windows.

Closes #4624

@SeanTAllen SeanTAllen requested a review from a team February 21, 2025 02:33
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 21, 2025
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Feb 21, 2025
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4625.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen changed the title Export runtime info methods Fix being unable to compile programs that use runtime info on Windows Feb 21, 2025
Note this would have been caught much earlier if we were building
examples on Windows as part of CI as there is a runtime info example
that would fail on Windows.

Closes #4624
@SeanTAllen SeanTAllen merged commit 72c5384 into main Feb 21, 2025
26 checks passed
@SeanTAllen SeanTAllen deleted the 4624 branch February 21, 2025 13:58
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 21, 2025
github-actions bot pushed a commit that referenced this pull request Feb 21, 2025
github-actions bot pushed a commit that referenced this pull request Feb 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't link runtime_info using program on Windows
2 participants