Skip to content

active-hint enhancements #544

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Sep 21, 2020
Merged

active-hint enhancements #544

merged 5 commits into from
Sep 21, 2020

Conversation

jmmaranan
Copy link
Contributor

@jmmaranan jmmaranan commented Sep 13, 2020

Fixes #219,

0 - gapped:
image

maximized:
image

@mmstick
Copy link
Member

mmstick commented Sep 17, 2020

What's left to get this ready? Would like to merge before stacking

@jmmaranan
Copy link
Contributor Author

jmmaranan commented Sep 17, 2020

The smart gap is not being identified properly. I added a function in window.ts and it doesn't work well. So i removed it for now.

@jmmaranan
Copy link
Contributor Author

@mmstick - since #219 did not originally define smart gaps, would it be acceptable? And also smart gaps is an experimental feature.

@jmmaranan jmmaranan marked this pull request as ready for review September 17, 2020 14:57
@jmmaranan
Copy link
Contributor Author

jmmaranan commented Sep 17, 2020

I will cleanup the logging later this afternoon on that last commit. And I think TESTING.md also needs to be updated.

@mmstick
Copy link
Member

mmstick commented Sep 17, 2020

If necessary, I can add what's needed to get smart gaps working with this

@jmmaranan
Copy link
Contributor Author

Sure. I will gladly take your help on that. I have a fix on the window when detached the other windows follow it. I was hoping to put that in another MR

@jmmaranan
Copy link
Contributor Author

But I cannot find the cause for why it doesn't detect the smart gapped flag

@mmstick mmstick requested a review from a team September 18, 2020 14:36
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will change the verbiage in the testing document to reflect that the active hint should no longer disappear for maximized windows in #526.

Full-screened apps still hide their hint, which is correct behavior.

I wanted to mention that when maximizing/un-maximizing (and also when using Ctrl-Super-Left/Right), the active hint moves to its new position before the window gets there (the active hint moves instantly, while the window's movement is animated by GNOME Shell.) This is the same behavior as current stable, it's just seen in more places because the hint was hidden on maximize/half-snapped before and now it's not. I don't think this is any more visually jarring than the rest of pop-shell's movements at this time.

@jacobgkau jacobgkau requested a review from a team September 18, 2020 18:38
@mmstick mmstick merged commit 8791171 into pop-os:master_focal Sep 21, 2020
@jmmaranan jmmaranan deleted the activehint_focal branch October 28, 2020 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show active hint" almost entirely disappears when the gap is set to "0".
3 participants