-
Notifications
You must be signed in to change notification settings - Fork 280
active-hint enhancements #544
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
What's left to get this ready? Would like to merge before stacking |
The smart gap is not being identified properly. I added a function in window.ts and it doesn't work well. So i removed it for now. |
I will cleanup the logging later this afternoon on that last commit. And I think TESTING.md also needs to be updated. |
If necessary, I can add what's needed to get smart gaps working with this |
Sure. I will gladly take your help on that. I have a fix on the window when detached the other windows follow it. I was hoping to put that in another MR |
But I cannot find the cause for why it doesn't detect the smart gapped flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I will change the verbiage in the testing document to reflect that the active hint should no longer disappear for maximized windows in #526.
Full-screened apps still hide their hint, which is correct behavior.
I wanted to mention that when maximizing/un-maximizing (and also when using Ctrl-Super-Left/Right), the active hint moves to its new position before the window gets there (the active hint moves instantly, while the window's movement is animated by GNOME Shell.) This is the same behavior as current stable, it's just seen in more places because the hint was hidden on maximize/half-snapped before and now it's not. I don't think this is any more visually jarring than the rest of pop-shell's movements at this time.
Fixes #219,
0 - gapped:

maximized:
