Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add thelio-mira-r4 #148

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add thelio-mira-r4 #148

merged 1 commit into from
Dec 13, 2024

Conversation

leviport
Copy link
Member

No description provided.

@leviport leviport requested review from a team December 11, 2024 23:32
garrettjwilke
garrettjwilke requested changes Dec 12, 2024
View reviewed changes
Copy link

@garrettjwilke garrettjwilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mira-r4 is not listed in the firmware section in settings.
screenshot attached:
firmware-mira-r4

@leviport
Copy link
Member Author

I got it to show up (I think it just needed updates), and now it prompts constantly about updates, even though there is no updated available.
IMG_20241213_142028_903

The version 3.11SP01 is what shows up in dmidecode, but it does not pass validation if I update the firmware changelog to match that:

     Running `firmware-edit/target/release/system76-firmware-edit validate thelio-mira-r4`
thelio-mira-r4 none
firmware-edit: failed to validate: Changelog entry 0 bios is '3.11.SP01', not '5.35'

@leviport leviport requested a review from a team December 13, 2024 22:43
@leviport
Copy link
Member Author

Ok, I think I fixed it in the validator. Ready for re-testing.

garrettjwilke
garrettjwilke approved these changes Dec 13, 2024
View reviewed changes
Copy link

@garrettjwilke garrettjwilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firmware-mira-r4-working

@leviport leviport merged commit f86dcf3 into master Dec 13, 2024
13 of 14 checks passed
@leviport leviport deleted the mira-r4 branch December 13, 2024 23:36
@leviport leviport mentioned this pull request Feb 11, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@garrettjwilke garrettjwilke garrettjwilke approved these changes

@jackpot51 jackpot51 jackpot51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leviport @garrettjwilke @jackpot51