Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix preview width if stack rows are too wide #54

Merged
merged 3 commits into from
May 22, 2024

Conversation

dunhamjared
Copy link
Contributor

@dunhamjared dunhamjared commented May 21, 2024

πŸ”— Linked issue

The preview width is too small when the stack rows are wide

Fix #53

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The goal of this PR is to:

  • Resolve layout issues when the stack row text is too wide
  • Minor improvements to flex implementation:
    • Applied minimum widths for frame-preview and frame-stack, grow to fill space
    • Updated error-frames to allow frame-preview and frame-stack to wrap if needed
    • Moved the order of elements within the error-frames div so flex-direction: row-reverse; is not required
    • Now using gap instead of margin
    • Removed media query code, not needed with the above changes

πŸ–ΌοΈ Screenshots

Before:

Screen.Recording.2024-05-21.at.8.25.10.AM.mov

After:

Screen.Recording.2024-05-21.at.8.59.10.AM.mov

After - but without the super long method name:

Screen.Recording.2024-05-21.at.9.00.12.AM.mov

πŸ“ Checklist

  • I have read the contribution guide.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@dunhamjared dunhamjared changed the title Flex updates Fix preview width if stack rows are too wide May 21, 2024
@thetutlage thetutlage merged commit 8e5de76 into poppinss:develop May 22, 2024
5 checks passed
@thetutlage
Copy link
Member

Thanks. It looks better for sure :)

@dunhamjared dunhamjared deleted the flex-updates branch January 15, 2025 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The preview width is too small when the stack rows are wide
2 participants