Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Externalize antenna calc and wav view #2498

Merged
merged 6 commits into from
Jan 26, 2025

Conversation

gullradriel
Copy link
Member

@gullradriel gullradriel commented Jan 26, 2025

In that PR I'm externalizing two apps, Antenna Length and WAV Viewer.
I also added a shell script in tools, to easily spot unused graphics files.

# Note:
If @bernd-herzog or anyone have an idea why firmware bin is bigger with those two externalized, I'm interested.

# The problem:
Firmware size before externalization (just fitting):

Space remaining in flash ROM: 352 bytes ( 0.0 %)

Firmware size after externalization (too big):

RuntimeError: SPI flash image size of 1049616 exceeds device size of 1048576 bytes

Correction

I found the error. Never forget to adjust an external app namespace.
This:

namespace ui {

Should become this:

using namespace ui; 
namespace ui::external_app::app_name {

Now the firmware space is reclaimed correctly:

Space remaining in flash ROM: 9232 bytes ( 0.9 %)

Ready to go !!

Copy link
Contributor

@u-foka u-foka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gullradriel gullradriel merged commit a65ef3c into portapack-mayhem:next Jan 26, 2025
3 checks passed
@gullradriel gullradriel deleted the externalize_app branch January 26, 2025 20:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants