Reference global variable explicitly

Reference `$global:PoshBotContext` instead of `PoshBotContext` so it's clear what variable we're using.
poshbotio · Oct 16, 2018 · e2ba9a3 · e2ba9a3
1 parent 45da649
commit e2ba9a3
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.11.3] Unreleased
+
+### Changes
+
+- Reference `$global:PoshBotContext` instead of `PoshBotContext` so it's clear what variable we're using.
+
 ## [0.11.2] 2018-10-11
 
 ### Added

diff --git a/PoshBot/PoshBot.psd1 b/PoshBot/PoshBot.psd1
@@ -12,7 +12,7 @@
 RootModule = 'PoshBot.psm1'
 
 # Version number of this module.
-ModuleVersion = '0.11.2'
+ModuleVersion = '0.11.3'
 
 # Supported PSEditions
 # CompatiblePSEditions = @()

diff --git a/PoshBot/Public/Get-PoshBotStatefulData.ps1 b/PoshBot/Public/Get-PoshBotStatefulData.ps1
@@ -13,7 +13,7 @@ function Get-PoshBotStatefulData {
         If specified, return only the value of the specified property Name
     .PARAMETER Scope
         Get stateful data from this scope:
-            Module: Data scoped to this plugin 
+            Module: Data scoped to this plugin
             Global: Data available to any Poshbot plugin
     .EXAMPLE
         $ModuleData = Get-PoshBotStatefulData
@@ -41,11 +41,11 @@ function Get-PoshBotStatefulData {
     )
     process {
         if($Scope -eq 'Module') {
-            $FileName = "$($PoshBotContext.Plugin).state"
+            $FileName = "$($global:PoshBotContext.Plugin).state"
         } else {
             $FileName = "PoshbotGlobal.state"
         }
-        $Path = Join-Path $PoshBotContext.ConfigurationDirectory $FileName
+        $Path = Join-Path $global:PoshBotContext.ConfigurationDirectory $FileName
 
         if(-not (Test-Path $Path)) {
             Write-Verbose "Requested stateful data file not found: [$Path]"
@@ -61,4 +61,4 @@ function Get-PoshBotStatefulData {
     }
 }
 
-Export-ModuleMember -Function 'Get-PoshBotStatefulData'
+Export-ModuleMember -Function 'Get-PoshBotStatefulData'
diff --git a/PoshBot/Public/Remove-PoshbotStatefulData.ps1 b/PoshBot/Public/Remove-PoshbotStatefulData.ps1
@@ -40,11 +40,11 @@ function Remove-PoshBotStatefulData {
     )
     process {
         if($Scope -eq 'Module') {
-            $FileName = "$($PoshBotContext.Plugin).state"
+            $FileName = "$($global:PoshBotContext.Plugin).state"
         } else {
             $FileName = "PoshbotGlobal.state"
         }
-        $Path = Join-Path $PoshBotContext.ConfigurationDirectory $FileName
+        $Path = Join-Path $global:PoshBotContext.ConfigurationDirectory $FileName
 
 
         if(-not (Test-Path $Path)) {
@@ -60,4 +60,4 @@ function Remove-PoshBotStatefulData {
     }
 }
 
-Export-ModuleMember -Function 'Remove-PoshBotStatefulData'
+Export-ModuleMember -Function 'Remove-PoshBotStatefulData'
diff --git a/PoshBot/Public/Set-PoshBotStatefulData.ps1 b/PoshBot/Public/Set-PoshBotStatefulData.ps1
@@ -55,11 +55,11 @@ function Set-PoshBotStatefulData {
         }
 
         if($Scope -eq 'Module') {
-            $FileName = "$($PoshBotContext.Plugin).state"
+            $FileName = "$($global:PoshBotContext.Plugin).state"
         } else {
             $FileName = "PoshbotGlobal.state"
         }
-        $Path = Join-Path $PoshBotContext.ConfigurationDirectory $FileName
+        $Path = Join-Path $global:PoshBotContext.ConfigurationDirectory $FileName
 
         if(-not (Test-Path $Path)) {
             $ToWrite = [pscustomobject]@{