Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When adding a channel rule the default does not get removed #131

Closed
DWOF opened this issue Nov 3, 2018 · 1 comment
Closed

When adding a channel rule the default does not get removed #131

DWOF opened this issue Nov 3, 2018 · 1 comment
Assignees
Labels

Comments

@DWOF
Copy link
Contributor

DWOF commented Nov 3, 2018

Expected Behavior

When setting the channel rules in the configuration it should replace the default rule that allows all commands in all channels

Current Behavior

When setting the channel rules in the configuration it merges with the default rule that allows all commands in all channels

Steps to Reproduce (for bugs)

$botParams = @{
BackendConfiguration = @{
        Name = 'SlackBackend'
        Token = 'XXXX'
    }
ChannelRules = @(
        @{
            Channel = 'bottestingfactory'
            IncludeCommands = @('*')
            ExcludeCommands = @()
          }
  )
}

$myBotConfig = New-PoshBotConfiguration @botParams

$myBotConfig.ChannelRules

Context

Unable to limit commands in slack channels

Your Environment

  • Module version used: 0.11.2
  • Operating System and PowerShell version: Windows 10 - 5.1.17134.228
DWOF added a commit to DWOF/PoshBot that referenced this issue Nov 3, 2018
@DWOF DWOF mentioned this issue Nov 3, 2018
9 tasks
@devblackops devblackops self-assigned this Nov 7, 2018
@devblackops devblackops added the bug label Nov 7, 2018
@devblackops
Copy link
Member

Thanks @DWOF! Fix merged in.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants