Fix ESLint errors #6201
Closed
Fix ESLint errors #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
softwarenerd
previously approved these changes
Feb 2, 2025
src/vs/platform/positronActionBar/browser/components/actionBarActionButton.tsx
Outdated
Show resolved
Hide resolved
dhruvisompura
force-pushed
the
fix/eslint-errors
branch
from
438f82e to
409b37f
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of merging 1.96 from upstream, ESLint was switched to use a flat config which we did not have setup. As a result, React linting from
eslint-plugin-reactandeslint-plugin-react-hookswere no longer configured for Positron. This problem was addressed in #6172.During the time period between merging 1.96 from upstream and #6172 being merged into main, we had uncaught React linting errors get pushed to main.
This PR aims to resolve the ESLint errors for all
*.tsxfiles.To only see ESLint errors the following command can be run :
npx eslint **/*.tsx --quietRelease Notes
New Features
Bug Fixes
QA Notes