Connections: Reduce accesses to the safe storage #6266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
jmcphers
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
LGTM!
A few additional QA notes from my testing:
- If a workspace was opened in a version of Positron before this change, it will still try to access safe storage when it opens
- There are a number of extensions (Quarto, Jupyter) that also access safe storage on boot. You will need to disable these to get a fully prompt-free startup. I've filed the Quarto issue here: Reading Zotero API key at startup causes safe storage prompt in Positron quarto-dev/quarto#659
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially adresses #2274
With this PR, the connections pane service will only try to access the safe storage if it has saved some state
to it before, thus reducing the 'Safe Storage' acess prompts to only when it really needs to store connections information.
Release Notes
New Features
Bug Fixes
QA Notes
This change should be transparent to users and all features in the connections pane should remain working.
@:connections