Skip to content

Require shinyswatch 0.7.0 and update examples accordingly #1558

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 18, 2024
Merged

Require shinyswatch 0.7.0 and update examples accordingly #1558

merged 6 commits into from
Jul 18, 2024

Conversation

cpsievert
Copy link
Collaborator

Will fix newly broken playwright tests

@cpsievert cpsievert requested a review from gadenbuie July 18, 2024 18:59
@cpsievert cpsievert changed the title Update todo_list example app to accomodate new shinyswatch release Require shinyswatch 0.7.0 and update examples accordingly Jul 18, 2024
gadenbuie
gadenbuie reviewed Jul 18, 2024
View reviewed changes
gadenbuie
gadenbuie reviewed Jul 18, 2024
View reviewed changes
gadenbuie
gadenbuie reviewed Jul 18, 2024
View reviewed changes
gadenbuie
gadenbuie approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Now that shinyswatch uses shiny.ui.Theme, the callable syntax is historical rather than preferred usage

@cpsievert @gadenbuie
Apply suggestions from code review
be252bd 
Co-authored-by: Garrick Aden-Buie <garrick@posit.co>
@schloerke schloerke enabled auto-merge July 18, 2024 19:49
@schloerke schloerke added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 636988d Jul 18, 2024
30 checks passed
@schloerke schloerke deleted the update-todo-list-example branch July 18, 2024 20:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@schloerke schloerke schloerke approved these changes

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpsievert @schloerke @gadenbuie