Skip to content

feat(Theme): Add .add_sass_layer_file() method #1790

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

gadenbuie
Copy link
Collaborator

Follows the Quarto implementation as described in
https://quarto.org/docs/output-formats/html-themes-more.html#bootstrap-bootswatch-layering.

See also https://rstudio.github.io/sass/reference/sass_layer.html
this method is functionally equivalent to sass::sass_layer_file().

Note that Quarto adds a uses layer that we also now support (above functions layer), which motivated adding an .add_uses() method for completeness.

@gadenbuie gadenbuie requested a review from cpsievert December 4, 2024 13:02
@gadenbuie
Copy link
Collaborator Author

Check failures seem to indicate we need to update chat to match recent ollama changes (with ollama 0.4.2).

@gadenbuie gadenbuie merged commit e802cfc into main Dec 4, 2024
38 of 40 checks passed
@gadenbuie gadenbuie deleted the feat/theme/add-sass-layer-file branch December 4, 2024 17:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants