Possible solution for #118

[bencripps]

This is one possible solution to the issue I posted. Not sure if this is how you'd like to resolve this, or if you have a higher level solution (that handles more than just the @extend example).

Let me know what you think; happy to make suggested changes.

[simonsmith]

Do we need to think about more than one extend here? Like:

.selector {
  @extend .test;
  @extend .blah;
}

Perhaps hasNoDeclarations needs to be repurposed/renamed to handle extra cases so that we only need to iterate with every once.

What do you think?

[bencripps]

That's a good point, I think that's a very real use case. I like the separation of having two functions, but I understand your point. If we kept the functions separate it would look like:

function isOnlyExtends(node) {
  return node.nodes && node.nodes.length && node.every(function(child) { 
    return child.type === 'atrule' && child.name === 'extend'
  });
}

What do you envision the repurposed version would look like?

[simonsmith]

On second thought I think your idea is better and the minimal overhead of two iterations allows the code to be clearer which I think is more important. Seeing as we now check the node.nodes in two places perhaps we could do:

function hasChildNodes(node) {
  return node.nodes && node.nodes.length;
}

function hasNoDeclarations(node) {
  return hasChildNodes(node) && node.every(function(child) {
    return child.type !== 'decl';
  });
}

function hasOnlyExtends(node) {
  return hasChildNodes(node) && node.every(function(child) { 
    return child.type === 'atrule' && child.name === 'extend';
  });
}

I was thinking that has instead of is reads a little better too?

[bencripps]

Agreed, I think this works. I'll amend my commit and push.

[simonsmith]

Could you amend the commit message to be a bit more descriptive? Otherwise I think this looks good!

[bencripps]

Amended and pushed, thanks!

[simonsmith]

Great stuff, thanks @bencripps

[bencripps]

Great, any chance of a getting this into a new release?

[simonsmith]

@bencripps Got a couple more changes to make and then I'll get a release out ASAP