Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow lint rule that contains @media (#134) #140

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

tardiva
Copy link

@tardiva tardiva commented Mar 22, 2019

We are trying to start using this plugin with stylelint-bem-selector-bem-pattern for our scss. While testing it we have found some issues. One of them was described in #134.

.page {
  padding: 20px;  

  &.menu_type_main { // the linter will skip this rule
    @media (min-width: $tablet-landscape) {
      display: block;
    }
  }
}

So, we fixed it and at the same time added another improvement. Comments placed inside the rule are now ignored when extracting selectors.

@simonsmith simonsmith merged commit 520600a into postcss:master Mar 25, 2019
@simonsmith
Copy link
Collaborator

Fantastic, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants