Pbckp 153 #500
Merged
Pbckp 153 #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directory (-X, --waldir=WALDIR)
…iles for the tests.option.OptionTest.test_help_1 and help_6
dlepikhova
approved these changes
Jun 22, 2022
avaness
reviewed
Jun 23, 2022
src/pg_probackup.c
Outdated
| @@ -122,6 +122,7 @@ static parray *datname_include_list = NULL; | |||
| /* arrays for --exclude-path's */ | |||
| static parray *exclude_absolute_paths_list = NULL; | |||
| static parray *exclude_relative_paths_list = NULL; | |||
| static char* waldir_path = NULL; | |||
There was a problem hiding this comment.
@VictorSpirin в качестве пожелания: переименовать глобальную переменную относительно так же называющихся параметров функции. иначе неочевидно где что используется. например во что-нибудь некрасивое типа g_waldir_path, чтобы остался зуд убрать переменную из глобального скоупа.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.