fix Makefile dist target #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the sparse.c and sscan.c files are now committed in src dir
esabol
approved these changes
Dec 6, 2023
|
@pdowler There is intention to remove these files from the src directory and auto-generate it. Can such possible change break your rule? |
|
When I added that rule back in 1.1.x those files were generated in the base dir and it was the quick and dirty way to make a src tarball... wasn't the right choice back then. Now, it looks like the C files are in src and committed to git so that is no longer needed. If there is a change in future to not have those generated C files committed, then next time around I'll fix the rpm build setup instead so it can generate them correctly. I don't know the pros and cons of those files being committed to git... probably wouldn't have been my choice (minimalist)., but I don't intend to change that. |
vitcpp
approved these changes
Dec 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sparse.c and sscan.c files are now committed in src dir
I use the dist target to create tarballs as part of building rpm packages.