PortManager #234
Merged
PortManager #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgresNode uses PostgresNodePortManager to reserve/release port number New PostgresNode RO-properties are added: - name - host - port - ssh_key
…nager__Global) It is a singleton.
- [del] TestTestgresLocal.test_pgbench - [del] TestTestgresRemote.test_pgbench
- test_port_rereserve_during_node_start - test_port_conflict
…sg_arg] - RemoteOperations::message - RemoteOperations::path_exists - RemoteOperations::is_port_free
Let's install it (netcat-traditional) explicitly.
A number of attempts is increased to 128. The previous value (10) is not enough and test could fail.
- [del] assert hasattr(os_ops, "host")
During this test we get another exception:
<[AttributeError("'PostgresNode' object has no attribute '_port'") raised in repr()] PostgresNode object at 0x782b67d79dc0>
Tests are added: - test_try_to_get_port_after_free_manual_port - test_try_to_start_node_after_free_manual_port
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Apr 22, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Apr 22, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Apr 22, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Apr 22, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234
fabriziomello
added a commit
to timescale/timescaledb
that referenced
this pull request
Apr 23, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234
timescale-automation
pushed a commit
to timescale/timescaledb
that referenced
this pull request
Apr 23, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234 (cherry picked from commit 3e61107)
timescale-automation
pushed a commit
to timescale/timescaledb
that referenced
this pull request
Apr 23, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234 (cherry picked from commit 3e61107)
kpan2034
pushed a commit
to kpan2034/timescaledb
that referenced
this pull request
Apr 28, 2025
A new testgres framework was released that makes `PostgresNode::port` read-only. Fixed it by properly set the port when initializing a new node. References: https://github.com/postgrespro/testgres/releases/tag/1.11.0 postgrespro/testgres#234
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main
Refactoring