compression modification #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard, from what I can tell, ZLib wraps the data (RFC 1950 around RFC 1951) making it incompatible with other libraries https://tools.ietf.org/html/draft-ietf-jose-json-web-encryption-10#section-4.1.4 http://stackoverflow.com/questions/15632979/java-decompressing-array-of-bytes
potatosalad
added a commit
that referenced
this pull request
Jul 8, 2016
potatosalad
added a commit
that referenced
this pull request
Jul 8, 2016
* Enhancements * Improved handling of RSA private keys in SMF (Straightforward * Method) form to CRT (Chinese Remainder Theorem) form, see * potatosalad/erlang-jose#19 This is especially useful for keys * produced by Java programs using the `RSAPrivateKeySpec` API as * mentioned in Section 9.3 of RFC 7517: * https://tools.ietf.org/html/rfc7517#section-9.3 * Updated EdDSA operations to comply with draft 04 of * https://tools.ietf.org/html/draft-ietf-jose-cfrg-curves-04. * Fixes * Fixed compression encoding bug for `{"zip":"DEF"}` operations * (thanks to @amadden734 see #3)
|
@amadden734 Awesome, thank you! This has been released as part of jose 1.1.2. |
potatosalad
added a commit
to potatosalad/erlang-jose
that referenced
this pull request
Jul 8, 2016
* Enhancements * Updated EdDSA tests to comply with draft 04 of https://tools.ietf.org/html/draft-ietf-jose-cfrg-curves-04 * Fixes * Fixed compression encoding bug for `{"zip":"DEF"}` operations (thanks to @amadden734 see potatosalad/ruby-jose#3)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating compress and uncompress methods to follow the RFC 1951 standard,
from what I can tell, ZLib wraps the data (RFC 1950 around RFC 1951) making
it incompatible with other libraries
https://tools.ietf.org/html/draft-ietf-jose-json-web-encryption-10#section-4.1.4
http://stackoverflow.com/questions/15632979/java-decompressing-array-of-bytes