Skip to content

Ponyfills for older browsers #15

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 26, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/built-in/binary-expression.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
var typeName = require('type-name');
var keys = Object.keys || require('object-keys');
var syntax = require('estraverse').Syntax;
var forEach = require('array-foreach');


function BinaryExpressionRenderer(traversal, config) {
Expand Down Expand Up @@ -32,13 +33,13 @@ function BinaryExpressionRenderer(traversal, config) {
});
traversal.on('render', function (writer) {
var pairs = [];
keys(_this.espathToPair).forEach(function (espath) {
forEach(keys(_this.espathToPair), function (espath) {
var pair = _this.espathToPair[espath];
if (pair.left && pair.right) {
pairs.push(pair);
}
});
pairs.forEach(function (pair) {
forEach(pairs, function (pair) {
_this.compare(pair, writer);
});
});
Expand Down
6 changes: 4 additions & 2 deletions lib/built-in/diagram.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strict';

var forEach = require('array-foreach');

function DiagramRenderer (traversal, config) {
this.config = config;
this.events = [];
Expand All @@ -21,7 +23,7 @@ function DiagramRenderer (traversal, config) {
traversal.on('render', function (writer) {
_this.events.sort(rightToLeft);
_this.constructRows(_this.events);
_this.rows.forEach(function (columns) {
forEach(_this.rows, function (columns) {
writer.write(columns.join(''));
});
});
Expand Down Expand Up @@ -67,7 +69,7 @@ DiagramRenderer.prototype.isOverlapped = function (prevCapturing, nextCaputuring
DiagramRenderer.prototype.constructRows = function (capturedEvents) {
var that = this;
var prevCaptured;
capturedEvents.forEach(function (captured) {
forEach(capturedEvents, function (captured) {
var dumpedValue = that.stringify(captured.value);
if (that.isOverlapped(prevCaptured, captured, dumpedValue)) {
that.addOneMoreRow();
Expand Down
5 changes: 3 additions & 2 deletions lib/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ var udiff = require('./udiff');
var defaultOptions = require('./default-options');
var typeName = require('type-name');
var extend = require('xtend');
var map = require('array-map');

// "Browserify can only analyze static requires. It is not in the scope of browserify to handle dynamic requires."
// https://github.com/substack/node-browserify/issues/377
Expand Down Expand Up @@ -51,13 +52,13 @@ function configure (options) {

function create (options) {
var config = configure(options);
var rendererClasses = config.renderers.map(function (rendererName) {
var rendererClasses = map(config.renderers, function (rendererName) {
return findRendererClass(rendererName, config);
});
return function (context) {
var traversal = new ContextTraversal(context);
var writer = new config.writerClass(extend(config));
var renderers = rendererClasses.map(function (RendererClass) {
var renderers = map(rendererClasses, function (RendererClass) {
return new RendererClass(traversal, extend(config));
});
traversal.emit('start', context);
Expand Down
6 changes: 4 additions & 2 deletions lib/traverse.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ var acorn = require('acorn');
var EventEmitter = require('events').EventEmitter;
var inherits = require('util').inherits;
var EsNode = require('./esnode');
var forEach = require('array-foreach');
var reduce = require('array-reduce');

function ContextTraversal (context) {
this.context = context;
Expand All @@ -14,7 +16,7 @@ inherits(ContextTraversal, EventEmitter);

ContextTraversal.prototype.traverse = function () {
var _this = this;
this.context.args.forEach(function (arg) {
forEach(this.context.args, function (arg) {
onEachEsNode(arg, _this.context.source.content, function (esNode) {
_this.emit('esnode', esNode);
});
Expand All @@ -24,7 +26,7 @@ ContextTraversal.prototype.traverse = function () {
function onEachEsNode(arg, jsCode, callback) {
var tokens = [];
var jsAST = acorn.parse(jsCode, {ecmaVersion: 6, locations: true, onToken: tokens});
var espathToValue = arg.events.reduce(function (accum, ev) {
var espathToValue = reduce(arg.events, function (accum, ev) {
accum[ev.espath] = ev.value;
return accum;
}, {});
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
},
"dependencies": {
"acorn": "^2.0.1",
"array-foreach": "^1.0.1",
"array-map": "0.0.0",
"array-reduce": "0.0.0",
"eastasianwidth": "^0.1.0",
"estraverse": "^4.1.0",
"googlediff": "^0.1.0",
Expand Down