Support yield statements #19
Conversation
jamestalmage
force-pushed
the
jt-yield-statements
branch
3 times, most recently
from
954f91a to
d14e0a8
Compare
|
@twada Also, just FYI - I don't know if you are an Intellij user, but if so, I hope you find this useful: https://github.com/jamestalmage/intellij-code-to-string-js |
jamestalmage
force-pushed
the
jt-yield-statements
branch
from
61e204a to
08955f8
Compare
| '}', | ||
| '', | ||
| 'var gen = myGenerator(3);', | ||
| 'gen.next().value.then((val) => gen.next(val)).catch(done);' |
There was a problem hiding this comment.
This exhausts the generator similar to how co would.
We could also just pull in co as a dev dependency if you want, but I opted to avoid adding another one for now.
There was a problem hiding this comment.
but I opted to avoid adding another one for now.
Agreed. Thanks.
|
@jamestalmage I've released espower 1.1.0 and restarted Travis build.
Wow this is so useful for creating our tests! |
|
woot! Green! |
jamestalmage
force-pushed
the
jt-yield-statements
branch
from
08955f8 to
5fb7050
Compare
| try { | ||
| top = ast = esprima.parse(jsCode, parserOptions()); | ||
| } catch (e) { | ||
| ast = esprima.parse(wrappedInGenerator(jsCode), parserOptions()); |
There was a problem hiding this comment.
Would you add inline comments explaining why this catch clause is needed and how it work? (just like a description of this pull-req)
From what I can tell, there is no way to get esprima to parse a yield statement that is not wrapped in a generator function. To work around this: try to parse normally first, then try parsing by wrapping with a generator statement. If it works the second time, then we assume it is due to a yield statement.
jamestalmage
force-pushed
the
jt-yield-statements
branch
from
5fb7050 to
7f9ac14
Compare
|
@jamestalmage Thank you for your great contribution! |
|
awesome! Thanks! |
|
Just released power-assert-formatter 1.2.0. Thank you for your great contribution! |
From what I can tell, there is no way to get esprima to parse a yield statement that is not wrapped in a generator function.
To work around this, I do the following:
This will require additional modifications on the instrumentation side of things before the output looks correct (my test will need to be modified at that point). The result of the yield is not captured.