Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support standard style definitions of transpirable es6 modules #37

Merged
merged 1 commit into from
Mar 9, 2016

Conversation

falsandtru
Copy link
Contributor

Please also review with other owners.

@twada
Copy link
Member

twada commented Dec 24, 2015

@falsandtru Thank you for your PR!!
Would you add some more explanation or reference URL for this PR?

@falsandtru
Copy link
Contributor Author

@twada
Copy link
Member

twada commented Dec 24, 2015

@falsandtru Thanks!

@teppeis @vvakame @azu Any thoughts?

@falsandtru
Copy link
Contributor Author

Another, how about #36 ?

@twada
Copy link
Member

twada commented Dec 24, 2015

@falsandtru Sorry for my late response about #36, replied and marked as wontfix for now though...

@falsandtru
Copy link
Contributor Author

Also TypeScript emits:

    Object.defineProperty(exports, "__esModule", { value: true });

@vvakame
Copy link
Member

vvakame commented Mar 8, 2016

sorry for late reply. LGTM. I think we can merge this PR.

@twada
Copy link
Member

twada commented Mar 8, 2016

@vvakame Thank you for your review!

@teppeis Would you review this too?

@falsandtru
Copy link
Contributor Author

Improved to Object.defineProperty(exports, "__esModule", { value: true });.

@twada
Copy link
Member

twada commented Mar 8, 2016

@falsandtru Thank you for your update.
Would you use define-properties for older browsers?

@falsandtru
Copy link
Contributor Author

@twada Changed to use define-properties.

@twada
Copy link
Member

twada commented Mar 8, 2016

@falsandtru LGTM.
Now we are going to merge and cut a new release soon.
Thank you for your contribution!

@falsandtru
Copy link
Contributor Author

All right.

log: change double quotes to single quotes.

twada added a commit that referenced this pull request Mar 9, 2016
Support standard style definitions of transpirable es6 modules
@twada twada merged commit 484b286 into power-assert-js:master Mar 9, 2016
@falsandtru falsandtru deleted the patch-1 branch March 9, 2016 04:04
@twada
Copy link
Member

twada commented Mar 9, 2016

Released as power-assert 1.3.0. Thank you for your contribution and reviews!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants