Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBIOS-420] Expose button variants on dialog kit #395

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

isismsilva
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
Fix Dialog kit to expose PBButtons setups.

Screenshots: Screenshots to visualize your addition/change

dialog.mov

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist

  • LABELS - Add a label: breaking, bug, improvement, documentation, or enhancement. See Labels for descriptions.
  • RELEASES - Add the appropriate label: Ready for Testing / Ready for Release
  • TESTING - Have you tested your story?

@isismsilva isismsilva added the Ready for Testing For anything that needs testing label Jun 12, 2024
@isismsilva isismsilva self-assigned this Jun 12, 2024
@isismsilva isismsilva requested a review from a team as a code owner June 12, 2024 19:53
@isismsilva isismsilva requested a review from Kbrinkley31 June 18, 2024 18:09
@co1in-1ewis co1in-1ewis added the Product Approved approved by product, pending code review and merge label Jun 26, 2024
@isismsilva isismsilva merged commit 6d12a72 into main Jun 27, 2024
2 checks passed
@isismsilva isismsilva deleted the PBIOS-420-dialog-button-fix branch June 27, 2024 13:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Product Approved approved by product, pending code review and merge Ready for Testing For anything that needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants