Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-18] Image kit animations #1675

Merged
merged 9 commits into from
Dec 16, 2021
Merged

[PLAY-18] Image kit animations #1675

merged 9 commits into from
Dec 16, 2021

Conversation

diontheroulde
Copy link
Contributor

@diontheroulde diontheroulde commented Nov 23, 2021 •
edited by pauljpark
Loading

Screens

UPDATED

image-kit-gif

Screen Shot 2021-11-18 at 3 10 50 PM

Breaking Changes

No

Runway Ticket URL

(https://nitro.powerhrg.com/runway/backlog_items/PLAY-18)

How to test this

yarn test -- app/pb_kits/playbook/pb_image/image.test.js

AND

bundle exec rspec

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@diontheroulde diontheroulde added enhancement New Features, Props, & Variants (USED IN CHANGELOG) wip breaking Indicates that a breaking change was introduced (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Nov 23, 2021
@diontheroulde diontheroulde requested a review from a team as a code owner November 23, 2021 15:57
@kre8sions kre8sions changed the title Image kit animations [PLAY-18] Image kit animations Dec 10, 2021
@diontheroulde diontheroulde requested a review from a team as a code owner December 15, 2021 16:47
@app-milano app-milano bot temporarily deployed to pr1675 December 15, 2021 19:01 Inactive
@pauljpark pauljpark added Needs Review and removed breaking Indicates that a breaking change was introduced (USED IN CHANGELOG) labels Dec 15, 2021
jasoncypret
jasoncypret previously requested changes Dec 15, 2021
View reviewed changes
@kre8sions kre8sions dismissed jasoncypret’s stale review December 16, 2021 13:50

resolved comments

@pauljpark pauljpark merged commit 0d83e8d into master Dec 16, 2021
@pauljpark pauljpark deleted the image-kit-animations branch December 16, 2021 13:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kre8sions kre8sions kre8sions approved these changes

@jasoncypret jasoncypret jasoncypret left review comments

Assignees

@pauljpark pauljpark

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diontheroulde @jasoncypret @kre8sions @pauljpark @jasperfurniss