Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-47] Allow rails pb_title to accept child text #1698

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

ns-ian
Copy link
Contributor

@ns-ian ns-ian commented Dec 17, 2021

Screens

Screenshot 2021-12-17 at 16-55-40 Playbook Design System

Breaking Changes

No - adds option to include text in a block, in addition to taking it as a prop (see screenshot)

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/PLAY-47

How to test this

[INSERT TESTING DETAILS]

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@ns-ian ns-ian added wip milano 20 MAX - Deploy this PR to a review environment via Milano labels Dec 17, 2021
@ns-ian ns-ian requested a review from a team as a code owner December 17, 2021 22:01
@app-milano app-milano bot temporarily deployed to pr1698 December 17, 2021 22:15 Inactive
@ns-ian ns-ian removed the wip label Dec 17, 2021
@kre8sions kre8sions added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Dec 20, 2021
@kre8sions kre8sions merged commit 7be6df3 into master Dec 20, 2021
@kre8sions kre8sions deleted the PLAY-47 branch December 20, 2021 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants