-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[PLAY-91] Add unique key prop to text input #1741
Conversation
4e80198
to
428cca4
Compare
ba96cd5
to
39d7c75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking about this more, if there is not a default then the key will always be the _className
prop string which will not be unique.
@thestephenmarshall Is there ever going to be a scenario where there isn't an 'id'? I just figured there would always be one. If not though, I can look into a function or something to generate unique id's. |
@kyleschechter of course there could be. Here you have an optional prop which means it can be |
This reverts commit c116cab.
Screens
Breaking Changes
No. A unique key prop was added to the actual input element of the Text Input kit, clearing the error message that usually persists in the console when working with this kit in React.
Runway Ticket URL
https://nitro.powerhrg.com/runway/backlog_items/PLAY-91
How to test this
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.Milano
label when you are ready for a review.