Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-2] Add flexbox props to all kits #1750

Merged
merged 19 commits into from
Feb 16, 2022

Conversation

RobGentile17
Copy link
Contributor

@RobGentile17 RobGentile17 commented Jan 27, 2022

Screens

DESKTOP:
Screen Shot 2022-02-02 at 4 11 07 PM

MOBILE:
Screen Shot 2022-02-02 at 4 11 46 PM

Breaking Changes

No. There was only the addition of new props, nothing changed or removed that would affect existing code in nitro.

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/PLAY-2

How to test this

alpha testing

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@RobGentile17 RobGentile17 requested a review from a team as a code owner January 27, 2022 17:20
@RobGentile17 RobGentile17 removed the wip label Feb 1, 2022
@RobGentile17 RobGentile17 changed the title WIP Add flexbox props to all kits [PLAY-2] Add flexbox props to all kits Feb 1, 2022
@RobGentile17 RobGentile17 added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 1, 2022
@jasperfurniss jasperfurniss force-pushed the add-flexbox-props-to-all-kits branch 2 times, most recently from 255a6b3 to 3d8ac57 Compare February 1, 2022 20:03
@RobGentile17 RobGentile17 force-pushed the add-flexbox-props-to-all-kits branch from ffdd1b0 to e9a3c80 Compare February 2, 2022 17:02
@app-milano app-milano bot temporarily deployed to pr1750 February 3, 2022 21:11 Inactive
@app-milano app-milano bot temporarily deployed to pr1750 February 14, 2022 18:25 Inactive
@thestephenmarshall
Copy link
Contributor

@RobGentile17 not sure about the conflict, but looks like it's time to GTM. 🚀

Copy link
Contributor

@kre8sions kre8sions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We need to add !important to the scss flex styles.
  • Also I noticed you are using flexStart and flexEnd if you are going to have those also add the normal start and end to the props where that is used @RobGentile17

@RobGentile17 RobGentile17 force-pushed the add-flexbox-props-to-all-kits branch from 6a1cbe0 to a1d989f Compare February 16, 2022 14:37
@RobGentile17 RobGentile17 force-pushed the add-flexbox-props-to-all-kits branch from a1d989f to 9013567 Compare February 16, 2022 14:39
@RobGentile17 RobGentile17 added the Ready for Release merged to master, ready for a versioned released label Feb 16, 2022
@RobGentile17 RobGentile17 merged commit fbf4b21 into master Feb 16, 2022
@RobGentile17 RobGentile17 deleted the add-flexbox-props-to-all-kits branch February 16, 2022 15:11
@RobGentile17 RobGentile17 removed the Ready for Release merged to master, ready for a versioned released label Feb 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano needs alpha testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants