-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[PLAY-2] Add flexbox props to all kits #1750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
255a6b3
to
3d8ac57
Compare
ffdd1b0
to
e9a3c80
Compare
jasperfurniss
approved these changes
Feb 14, 2022
jasoncypret
previously requested changes
Feb 14, 2022
RobGentile17
commented
Feb 14, 2022
RobGentile17
commented
Feb 14, 2022
thestephenmarshall
approved these changes
Feb 15, 2022
@RobGentile17 not sure about the conflict, but looks like it's time to GTM. 🚀 |
jasoncypret
approved these changes
Feb 15, 2022
kre8sions
reviewed
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We need to add !important to the scss flex styles.
- Also I noticed you are using flexStart and flexEnd if you are going to have those also add the normal start and end to the props where that is used @RobGentile17
6a1cbe0
to
a1d989f
Compare
a1d989f
to
9013567
Compare
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
needs alpha testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
DESKTOP:

MOBILE:

Breaking Changes
No. There was only the addition of new props, nothing changed or removed that would affect existing code in nitro.
Runway Ticket URL
https://nitro.powerhrg.com/runway/backlog_items/PLAY-2
How to test this
alpha testing
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.Milano
label when you are ready for a review.