Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-112] Size Prop styling needs to be corrected: Image Kit #1756

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

JelenaD1
Copy link
Contributor

@JelenaD1 JelenaD1 commented Jan 31, 2022

Screens

BEFORE

Playbook_Design_System

AFTER

Playbook_Design_System

Breaking Changes

This will add word size on image kits but the actual size will remain the same. The only thing we need to do is make sure image kits with size on are not being targeted anywhere in Nitro so we can safely update the classname.

Runway Ticket URL

[INSERT URL]

How to test this

Add a margin or padding prop to the image kit and see if image size will change.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@JelenaD1 JelenaD1 requested a review from a team as a code owner January 31, 2022 19:31
@JelenaD1 JelenaD1 self-assigned this Jan 31, 2022
@JelenaD1 JelenaD1 added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Needs Review labels Jan 31, 2022
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until alpha testing completed. Standby for release.

@JelenaD1
Copy link
Contributor Author

@thestephenmarshall we also alpha tested this one- needs review and we can merge it.

@thestephenmarshall thestephenmarshall merged commit cbc4a64 into master Feb 14, 2022
@thestephenmarshall thestephenmarshall deleted the PCA/Imag-kit-size-prop-bug branch February 14, 2022 17:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants