Addressing deprecation warning in order to avoid using Kernel.open #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delucas
added
the
improvement
thestephenmarshall
added
the
milano
|
@delucas thanks for opening this PR. I am deploying to milano and will check the results soon. |
thestephenmarshall
requested changes
Feb 14, 2022
There was a problem hiding this comment.
@delucas Looks like something is blowing up in this PR https://pr1778.playbook.beta.hq.powerapp.cloud/kits/icon/rails
thestephenmarshall
approved these changes
Feb 16, 2022
|
@thestephenmarshall thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
No. Should address a single Deprecation Warning.
Runway Ticket URL
HFH-705
How to test this
[INSERT TESTING DETAILS]
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.