Add form as a prop for button kit #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows forms to be connected to a button that is created outside of the form
nehaabraham
added
enhancement
|
|
thestephenmarshall
approved these changes
Mar 1, 2022
| @@ -15,6 +15,7 @@ type ButtonPropTypes = { | |||
| data?: object, | |||
| disabled?: boolean, | |||
| fixedWidth?: boolean, | |||
| form?: string, | |||
There was a problem hiding this comment.
@nehaabraham I made this optional since there will be many instances in Nitro which will not be sending this prop. Once this kit is converted to Typescript, not having the optional ? will throw errors.
| it "form", :aggregate_failures do | ||
| expect(subject.new(form: "form-id").options).to include(:form) | ||
| expect(subject.new.options).to_not include(:form) | ||
| end |
There was a problem hiding this comment.
@nehaabraham I also added a test to ensure that form prop is present when sent.
thestephenmarshall
added
Ready for Release
thestephenmarshall
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows forms to be connected to a button that is created outside of the form.
Screens
[INSERT SCREENSHOT]
Breaking Changes
[Yes/No (Explain)]
Runway Ticket URL
[INSERT URL]
How to test this
[INSERT TESTING DETAILS]
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.