Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates Visual Guidelines Color Partial to TSX #1899

Merged
merged 7 commits into from
Jun 6, 2022

Conversation

GordonHodanich
Copy link

@GordonHodanich GordonHodanich commented May 12, 2022

ScreenShot:
Playbook_Design_System

Breaking Changes

No, reproduced the Visual Guidelines Color partial to be displayed in the visual_guidelines_react page

Runway Ticket URL

PLAY-164

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.

thestephenmarshall and others added 2 commits May 5, 2022 10:18
* Removed flow and Renamed file

* Updated Types

* Removed JSX file extentions from imports

* Fix syntax error

* Fix tests

Co-authored-by: Erica Winne <erica.winne@powerhrg.com>
* Started Converting

* Rename file to TSX and Updated types

* Added/Joined & GlobalProps

* Merge Master

* Changed back default blank string

Co-authored-by: Erica Winne <erica.winne@powerhrg.com>
@GordonHodanich GordonHodanich added milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels May 12, 2022
@GordonHodanich GordonHodanich requested a review from a team as a code owner May 12, 2022 19:41
@GordonHodanich GordonHodanich self-assigned this May 12, 2022
@GordonHodanich GordonHodanich added wip and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels May 12, 2022
@thestephenmarshall thestephenmarshall force-pushed the master branch 2 times, most recently from 4755d3c to 9a62f6e Compare May 13, 2022 13:30
@GordonHodanich GordonHodanich force-pushed the Play/switch_color_partials_to_react branch from 8c5852e to 9d27749 Compare May 16, 2022 14:36
@GordonHodanich GordonHodanich added milano 20 MAX - Deploy this PR to a review environment via Milano and removed wip labels May 16, 2022
@app-milano app-milano bot temporarily deployed to pr1899 May 16, 2022 17:44 Inactive
@GordonHodanich GordonHodanich changed the title [PLAY-164] Convert visual guidelines Color partial to TSX Updates Visual Guidelines Color Partial to TSX May 17, 2022
@thestephenmarshall thestephenmarshall self-requested a review May 18, 2022 14:44
@thestephenmarshall thestephenmarshall added the Ready for Release merged to master, ready for a versioned released label May 23, 2022
@thestephenmarshall thestephenmarshall removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Jun 6, 2022
@thestephenmarshall thestephenmarshall merged commit bedb9fb into master Jun 6, 2022
@thestephenmarshall thestephenmarshall deleted the Play/switch_color_partials_to_react branch June 6, 2022 20:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants