[Play-159] Play Adding Alert To Dialog Kit #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CooperSawyer1
changed the title
CooperSawyer1
added
new kit
CooperSawyer1
changed the title
thestephenmarshall
force-pushed
the
play-adding-alert-to-dialog-kit
branch
from
386ca4b to
a913c77
Compare
thestephenmarshall
force-pushed
the
play-adding-alert-to-dialog-kit
branch
2 times, most recently
from
0e46ca5 to
09989fa
Compare
thestephenmarshall
force-pushed
the
play-adding-alert-to-dialog-kit
branch
from
09989fa to
e84eef7
Compare
thestephenmarshall
approved these changes
May 26, 2022
thestephenmarshall
added
Ready for Release
thestephenmarshall
force-pushed
the
master
branch
from
21f3545 to
b412945
Compare
| </If> | ||
|
|
||
| <Dialog.Body> | ||
| <Flex align='center' |
There was a problem hiding this comment.
We can't center all dialogs by default. This breaks all existing dialogs that do not want centered text.
There was a problem hiding this comment.
We also still need these conditionals that were deleted:
<If condition={title}>
<Dialog.Header>{title}</Dialog.Header>
</If>
<If condition={text}>
<Dialog.Body>{text}</Dialog.Body>
</If>
I'm going to try to add before/after screenshots to the story to document what is broken.
thestephenmarshall
added a commit
that referenced
this pull request
Jul 7, 2022
This reverts commit bbc147d.
thestephenmarshall
added a commit
that referenced
this pull request
Jul 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Here are the new additions to the Dialog page.
Here are examples of the new Dialog Alerts icons
Here are examples of the styles that can be used.
Breaking Changes
[Yes/No (Explain)]
Runway Ticket URL
[INSERT URL]
How to test this
[INSERT TESTING DETAILS]
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.