Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-169] Create React Spacing Partial #1916

Merged
merged 11 commits into from
Jun 7, 2022

Conversation

THElvan
Copy link
Member

@THElvan THElvan commented May 20, 2022

React Kit Coverage
Screen Shot 2022-05-20 at 10 46 36 AM

Breaking Changes

Yes, there was a change made to the example partial so that we can properly display multiple props.

Runway Ticket URL

Play-169

How to test this

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@THElvan THElvan added milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels May 20, 2022
@THElvan THElvan self-assigned this May 20, 2022
@THElvan THElvan requested a review from a team as a code owner May 20, 2022 15:23
@app-milano app-milano bot temporarily deployed to pr1916 May 20, 2022 15:45 Inactive
@app-milano app-milano bot temporarily deployed to pr1916 May 20, 2022 16:15 Inactive
THElvan and others added 2 commits May 24, 2022 10:40
* Fixed bug

* Went with top
…ook (#1927)

* Update view_component requirement from = 2.48.0 to = 2.55.0 in /playbook

Updates the requirements on [view_component](https://github.com/github/view_component) to permit the latest version.
- [Release notes](https://github.com/github/view_component/releases)
- [Changelog](https://github.com/github/view_component/blob/main/docs/CHANGELOG.md)
- [Commits](ViewComponent/view_component@v2.48.0...v2.55.0)

---
updated-dependencies:
- dependency-name: view_component
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update website Gemfile.lock

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
ryanmrodriguez and others added 4 commits May 24, 2022 11:56
Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
* Converting title kit to ts (#1872)

* Removed flow and Renamed file

* Updated Types

* Removed JSX file extentions from imports

* Fix syntax error

* Fix tests

Co-authored-by: Erica Winne <erica.winne@powerhrg.com>

* Converting caption to tsx (#1874)

* Started Converting

* Rename file to TSX and Updated types

* Added/Joined & GlobalProps

* Merge Master

* Changed back default blank string

Co-authored-by: Erica Winne <erica.winne@powerhrg.com>

* Create cursor partial in tsx

Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
Co-authored-by: Erica Winne <erica.winne@powerhrg.com>
Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
@thestephenmarshall thestephenmarshall added Ready for Release merged to master, ready for a versioned released and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels May 26, 2022
@thestephenmarshall thestephenmarshall force-pushed the PLAY-169-spacing-partial-to-react branch from 4df96c1 to bad99bf Compare June 6, 2022 20:11
@thestephenmarshall thestephenmarshall added not ready and removed Ready for Release merged to master, ready for a versioned released labels Jun 6, 2022
@thestephenmarshall thestephenmarshall added Ready for Release merged to master, ready for a versioned released and removed not ready labels Jun 6, 2022
@thestephenmarshall thestephenmarshall merged commit 5e5b1c2 into master Jun 7, 2022
@thestephenmarshall thestephenmarshall deleted the PLAY-169-spacing-partial-to-react branch June 7, 2022 16:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants