Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert Back to TS and Fix Props in Radio Kit Input Field #1970

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Revert Back to TS and Fix Props in Radio Kit Input Field #1970

merged 1 commit into from
Jul 18, 2022

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented Jul 18, 2022 •
edited
Loading

React Kit Coverage
Converts Radio kit back to TS and fixes props within the Radio kit inner input field which cause checked attribute to remain unchanged until interacted with.

Screens

NO

Breaking Changes

NO

Runway Ticket URL

Story

How to test this

  • ONe
  • Two

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@thestephenmarshall thestephenmarshall requested a review from a team as a code owner July 18, 2022 18:28
@thestephenmarshall thestephenmarshall self-assigned this Jul 18, 2022
@thestephenmarshall thestephenmarshall added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 18, 2022
@thestephenmarshall thestephenmarshall merged commit 010c74d into master Jul 18, 2022
@thestephenmarshall thestephenmarshall deleted the fix-radio-ts branch July 18, 2022 20:07
@jasperfurniss jasperfurniss added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Jul 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss Awaiting requested review from jasperfurniss

Assignees

@thestephenmarshall thestephenmarshall

Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thestephenmarshall @jasperfurniss