Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-121] Add Sidenav to the Visual Guidelines Page #1972

Merged
merged 6 commits into from
Jul 26, 2022

Conversation

augustomallmann
Copy link
Contributor

@augustomallmann augustomallmann commented Jul 21, 2022

React Kit Coverage

Screens

Screen Shot 2022-07-21 at 1 58 48 PM

Breaking Changes

No breaking changed. Added a sidebar to the visual_guidelines route. When the user clicks on any link, he's dragged to the section corresponding to the ID.

Runway Ticket URL

PLAY-121

How to test this

[INSERT TESTING DETAILS]

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@augustomallmann augustomallmann added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 21, 2022
@augustomallmann augustomallmann requested a review from a team as a code owner July 21, 2022 16:55
@augustomallmann augustomallmann added the enhancement New Features, Props, & Variants (USED IN CHANGELOG) label Jul 21, 2022
@app-milano app-milano bot temporarily deployed to pr1972 July 21, 2022 17:17 Inactive
@jasperfurniss
Copy link
Contributor

jasperfurniss commented Jul 22, 2022

@augustomallmann
A few of the links are broken: Display, Cursor, and FlexBox. https://pr1972.playbook.beta.hq.powerapp.cloud/visual_guidelines#shadows

Also, can you make the footer not visible, until you actually scroll all the way to the bottom.
It may require you to give the left sidebar a specific height of some type.
But it just looks funny on my screen at the moment because half of the footer is always showing when you are click the items.

@augustomallmann
Copy link
Contributor Author

Also, can you make the footer not visible, until you actually scroll all the way to the bottom.
It may require you to give the left sidebar a specific height of some type.
But it just looks funny on my screen at the moment because half of the footer is always showing when you are click the items.

Hey @jasperfurniss. Thanks for the great feedback!

  • I fixed the links
  • About the footer, it happens because the if you scroll with your cursor on the sidebar it drags you straight to the footer. The pb--page--content--main is a div that already has scroll. My suggestion is to add the footer inside the pb--page--content--main div, making it appears only after the user reads all the content, but it won't be full width. What do you think ? I pushed this example so you can check it in the milano server

@app-milano app-milano bot temporarily deployed to pr1972 July 22, 2022 16:09 Inactive
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
11.2.6 enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants