Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-215]- Typescript conversion of Contact Kit #1984

Merged
merged 1 commit into from
Aug 5, 2022
Merged

[PLAY-215]- Typescript conversion of Contact Kit #1984

merged 1 commit into from
Aug 5, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Jul 29, 2022 •
edited by github-actions bot
Loading

React Kit Coverage

Screens

Screen Shot 2022-07-29 at 8 27 44 AM

Breaking Changes

No breaking changes, JSX to TSX conversion.

Runway Ticket URL

PLAY-215

How to test this

[INSERT TESTING DETAILS]

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels Jul 29, 2022
@nidaqg nidaqg requested a review from a team as a code owner July 29, 2022 12:39
augustomallmann
augustomallmann approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@augustomallmann augustomallmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@malekphrg malekphrg self-requested a review August 1, 2022 12:45
malekphrg
malekphrg reviewed Aug 1, 2022
View reviewed changes
Copy link

@malekphrg malekphrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jasperfurniss jasperfurniss merged commit 21e7ca6 into master Aug 5, 2022
@jasperfurniss jasperfurniss deleted the PLAY-215-TS-conversion-contact branch August 5, 2022 02:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@malekphrg malekphrg malekphrg left review comments

@augustomallmann augustomallmann augustomallmann approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees
No one assigned
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nidaqg @augustomallmann @jasperfurniss @malekphrg