Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Play-220] - Typescript Conversion of Date Kit #1998

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Aug 5, 2022

Screens

Screen Shot 2022-08-05 at 9 00 58 AM

Screen Shot 2022-08-05 at 9 01 03 AM

Screen Shot 2022-08-05 at 9 01 09 AM

Breaking Changes

No Breaking changes. PR converts date.js and dateTime.js to typescript

Runway Ticket URL

Runway Story

How to test this

Review in Milano environment

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels Aug 5, 2022
@nidaqg nidaqg requested a review from jasperfurniss August 5, 2022 13:15
@nidaqg nidaqg requested a review from a team as a code owner August 5, 2022 13:15
@app-milano app-milano bot temporarily deployed to pr1998 August 5, 2022 13:37 Inactive
@app-milano app-milano bot temporarily deployed to pr1998 August 8, 2022 14:36 Inactive
@jasperfurniss jasperfurniss added Ready for Release merged to master, ready for a versioned released and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Aug 23, 2022
@jasperfurniss jasperfurniss merged commit 54d3481 into master Aug 26, 2022
@jasperfurniss jasperfurniss deleted the PLAY-220-TS-conversion-date-kit branch August 26, 2022 16:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants