Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-255]-TS Conversion of Fixed Confirmation Toast #2007

Merged
merged 3 commits into from
Aug 26, 2022
Merged

[PLAY-255]-TS Conversion of Fixed Confirmation Toast #2007

merged 3 commits into from
Aug 26, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Aug 11, 2022

Screens

Playbook-Design-System (1)

Breaking Changes

No Breaking changes, just converts all .jsx files in confirmation toast kit to .tsx

Runway Ticket URL

Runway Story

How to test this

[INSERT TESTING DETAILS]

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels Aug 11, 2022
@nidaqg nidaqg requested a review from a team as a code owner August 11, 2022 16:23
@app-milano app-milano bot temporarily deployed to pr2007 August 11, 2022 16:36 Inactive
@app-milano app-milano bot temporarily deployed to pr2007 August 15, 2022 13:31 Inactive
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Aug 23, 2022
@jasperfurniss jasperfurniss merged commit da79ea7 into master Aug 26, 2022
@jasperfurniss jasperfurniss deleted the PLAY-255-TS-conversion-confirmation-toast branch August 26, 2022 16:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@augustomallmann augustomallmann Awaiting requested review from augustomallmann

Assignees
No one assigned
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidaqg @jasperfurniss