Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-266] Typescript Conversion: Layout #2051

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Conversation

augustomallmann
Copy link
Contributor

Screens

Screen Shot 2022-09-05 at 12 15 36 PM

Breaking Changes

No breaking changes. Typescript conversion of the layout Kit and Jest test.

Runway Ticket URL

[PLAY-266]

How to test this

Create multiple versions of the Layout Kit.
Run yarn test.
Check for console or visual errors.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@augustomallmann augustomallmann added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels Sep 5, 2022
@augustomallmann augustomallmann requested a review from a team as a code owner September 5, 2022 15:18
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Sep 9, 2022
@jasperfurniss jasperfurniss merged commit 8483e8a into master Sep 10, 2022
@jasperfurniss jasperfurniss deleted the typescript-layout branch September 10, 2022 14:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants