[Play-311] - Add Sidebar For Visual Guidelines React Page #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
milano
nidaqg
requested review from
augustomallmann,
jasperfurniss and
Israel-Molestina
thestephenmarshall
approved these changes
Sep 7, 2022
| "Flex Box", | ||
| ]; | ||
|
|
||
| const ReactSidebar = () => { |
There was a problem hiding this comment.
Could we just called this Sidebar? I don't know why we would need to add React to the naming unless I'm missing something.
There was a problem hiding this comment.
Will make that change 👍🏽
|
|
||
| export default VisualGuidelines | ||
| export default VisualGuidelines; |
There was a problem hiding this comment.
Thanks for converting the singles to doubles and adding those anchor links! 🚀
| <% end %> | ||
|
|
||
| <% if current_page?('/visual_guidelines_react') %> | ||
| <%= react_component("ReactSidebar") %> | ||
| <% end %> |
There was a problem hiding this comment.
Suggested change
| <% end %> | |
| <% end %> | |
jasperfurniss
added
the
Ready for Release
jasperfurniss
approved these changes
Sep 10, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
No breaking changes, adding to playbook website only
Runway Ticket URL
Runway Story
How to test this
Test in milano env
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.